Add flag to configure API & dashboard's write timeouts #4474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Phillips <jamesdphillips@gmail.com>
Signed-off-by: James Phillips <jamesdphillips@gmail.com>
Signed-off-by: James Phillips <jamesdphillips@gmail.com>
Signed-off-by: James Phillips <jamesdphillips@gmail.com>
amdprophet
approved these changes
Nov 1, 2021
Signed-off-by: James Phillips <jamesdphillips@gmail.com>
ccressent
reviewed
Nov 2, 2021
|
Yes please @ccressent! I think using the string representation of time.Duration should be our standard, considering it has first class support in our argument parser. |
amdprophet
requested changes
Nov 2, 2021
backend/cmd/start.go
Outdated
| @@ -512,12 +518,14 @@ func flagSet(server bool) *pflag.FlagSet { | |||
| flagSet.String(flagAPIListenAddress, viper.GetString(flagAPIListenAddress), "address to listen on for api traffic") | |||
| flagSet.Int64(flagAPIRequestLimit, viper.GetInt64(flagAPIRequestLimit), "maximum API request body size, in bytes") | |||
| flagSet.String(flagAPIURL, viper.GetString(flagAPIURL), "url of the api to connect to") | |||
| flagSet.Int64(flagAPIWriteTimeout, viper.GetInt64(flagAPIWriteTimeout), "maximum duration before timing out writes of responses") | |||
There was a problem hiding this comment.
As the others have mentioned, let's use viper.GetDuration() here instead and update the types surrounding this flag to time.Duration.
Signed-off-by: James Phillips <jamesdphillips@gmail.com>
|
@ccressent good call! updated to use |
|
Bit of a bummer but I can't think of an easy way to migrate |
|
@jamesdphillips yeah it's fine to leave it as is. We can add it to the list of things we want to break with 7.x... |
amdprophet
approved these changes
Nov 4, 2021
ccressent
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
api-write-timeout&dashboard-write-timeoutflags to allow users to configure the respective HTTP server's write timeout. Useful when some requests might reasonably take more than a few seconds to complete.Signed-off-by: James Phillips jamesdphillips@gmail.com