Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphQL] Return nil when no mutator is present on handler #3090

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

jamesdphillips
Copy link
Contributor

Signed-off-by: James Phillips jamesdphillips@gmail.com

What is this change?

Return nil when no mutator is present on source handler.

Why is this change necessary?

Without this change, the client will attempt to list all mutators, leading to an error when trying to unmarshal the response to a single mutator.

Does your change need a Changelog entry?

Unlikely.

Do you need clarification on anything?

No.

Were there any complications while making this change?

Nope!

Have you reviewed and updated the documentation for this change? Is new documentation required?

No changes required.

How did you verify this change?

Unit test & manual.

Signed-off-by: James Phillips <jamesdphillips@gmail.com>
Copy link
Contributor

@wesleycyu wesleycyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! 🎉

@jamesdphillips jamesdphillips merged commit c80ddea into master Jun 25, 2019
@jamesdphillips jamesdphillips deleted the jdp/fixup-handler-mutator-field branch June 25, 2019 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants