[Web UI] Create separate vendor and lib DLL bundles #2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neal Granger <neal@nealg.com>
Signed-off-by: Neal Granger <neal@nealg.com>
jamesdphillips
suggested changes
Mar 21, 2019
| <link rel="manifest" href="${require('./manifest.macro.js')}"> | ||
|
|
||
| <!-- Windows 8.1 + IE11 and above --> | ||
| <meta name="msapplication-config" content="${require('./browserconfig.macro.js')}" /> |
| @@ -115,20 +116,18 @@ class SilencesListItem extends React.Component { | |||
| paddingTop: 8, // one spacing unit | |||
| }} | |||
| > | |||
| <Maybe value={silence.creator}> | |||
There was a problem hiding this comment.
I think this may be a regression that was introduced in the rebase. See: #2817.
There was a problem hiding this comment.
good catch! This is one of two conflicts I had to resolve
Signed-off-by: Neal Granger <neal@nealg.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
This change breaks the single Web UI client bundle into multiple bundles.
Core components and shared dependencies are provided by "lib" and "vendor" bundles that can be referenced by downstream webpack builds allowing them to add additional functionality to the core Web UI app.
Why is this change necessary?
This changes enables the creation of the Sensu Enterprise Web UI. (https://github.com/sensu/sensu-enterprise-go/issues/229)
Does your change need a Changelog entry?
Yes.
Do you need clarification on anything?
No.
Were there any complications while making this change?
This feature required major changes of the Web UI codebase and build directory structures.
The dashboard assets go generate logic does not support the changes to the build directory structure - regenerated assets are intentionally omitted from this PR to avoid breaking things.
The
yarn startscript no longer runs a build and does not reload changes while the server is running. It is necessary toyarn buildand re-runyarn startto see any changes in the browser. Depending on the scope of the changes, it may be possible to runyarn build:apporyarn build:lib && yarn build:appto speed things up.Have you reviewed and updated the documentation for this change? Is new documentation required?
No,
How did you verify this change?
By running
yarn testand by manual Web UI testing.