Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sidekiq 6.0 #6

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Allow sidekiq 6.0 #6

merged 2 commits into from
Dec 7, 2023

Conversation

sensorsasha
Copy link
Contributor

@sensorsasha sensorsasha commented Nov 30, 2023

Overview

This PR allows sidekiq 6.0. I couldn't find any breaking changes related to this gem in the sidekiq 6 diff. This seems to be a safe upgrade.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d09d540) 96.91% compared to head (384923a) 96.91%.

❗ Current head 384923a differs from pull request most recent head b0ab4fb. Consider uploading reports for the commit b0ab4fb to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   96.91%   96.91%           
=======================================
  Files          15       15           
  Lines         422      422           
=======================================
  Hits          409      409           
  Misses         13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanl-st
Copy link
Contributor

@ixti do you want to take a look?

@ixti
Copy link
Contributor

ixti commented Nov 30, 2023

Yeah this upgrade should be very safe. If my memory does not fail me, the "fun" bits only start with Sidekiq 6.5.x

@kevinrobell-st
Copy link
Contributor

Make sure to tag a new release after merging since the version has been bumped.

@sensorsasha sensorsasha merged commit 5e84543 into master Dec 7, 2023
7 checks passed
@sensorsasha sensorsasha deleted the allow_sidekiq_6 branch December 7, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants