Skip to content

Conversation

@tomcombriat
Copy link
Collaborator

This fixes #171.
@tfry-git and @sensorium if you comments on the naming please let me know.

Otherwise I'll merge it soon!

Cheers,
Tom

@tfry-git
Copy link
Collaborator

An alternative might be to share the same enum between both classes. I see no immediate downside to having one header including the other (ok, compilation will be a miniscule bit slower, but the compiled code should not be any different), so it would only have to be defined in one of them. This would avoid the cumbersome naming.

@tomcombriat
Copy link
Collaborator Author

Ah yeah, this came to mind at some point but was feeling a bit unconfident about for instance including ResonantFilter.h into StateVariableh. I guess compilation will be a bit longer, but the "unneeded" functions should not be included into the final executable right?

@tomcombriat
Copy link
Collaborator Author

tomcombriat commented Feb 20, 2023

@tfry-git It compiles fine.
(Sorry for three commits for one line, will try to squash them)
Have squashed them.

@tomcombriat tomcombriat merged commit 1558ab1 into sensorium:master Feb 22, 2023
@tomcombriat tomcombriat deleted the fixResonantFilter branch April 11, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conflict between StateVariable and ResonantFilter enum filter types

2 participants