Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_copy_meta_inf: accept all legal base file names #299

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

dnet
Copy link
Contributor

@dnet dnet commented Nov 19, 2019

As the documentation states:

If the alias name contains any characters that are not allowed in a signature file name, each such character is converted to an underscore ("_") character in forming the file name. Legal characters include letters, digits, underscores, and hyphens.

This commit adds the missing part to the regex: digits, underscore and hyphen, so that all key names are covered, otherwise there could be multiple signature files, resulting in confused verifiers.

As the documentation states:

> If the alias name contains any characters that are not allowed in a
> signature file name, each such character is converted to an underscore
> ("_") character in forming the file name. Legal characters include
> letters, digits, underscores, and hyphens.

This commit adds the missing part to the regex: digits, underscore and
hyphen, so that all key names are covered, otherwise there could be
multiple signature files, resulting in confused verifiers.
@leonjza
Copy link
Member

leonjza commented Nov 19, 2019

Thanks!

@leonjza leonjza merged commit 2f1e051 into sensepost:master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants