added sps30 to newBox form #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
will do lint and stuff tomorrow, nothing to see here just yet |
mpfeil
requested changes
Dec 16, 2022
Member
mpfeil
left a comment
mpfeil
left a comment
There was a problem hiding this comment.
Could you also add the new sensor to the senseBox:edu hardware setup section
Thiemann96
commented
Jan 31, 2023
Contributor
Author
Thiemann96
left a comment
Thiemann96
left a comment
There was a problem hiding this comment.
added in 55e7728
Member
|
Nice update. @Thiemann96 one last thing. Could you check out the conflicts within the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix or Enhancement and description?
Added the option to add SPS30 to the home setup at the registration of a new box.
Environment