Refactor to decouple kinesis and the client #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wchan2
force-pushed
the
refactor-to-decouple-kinesis-and-the-client
branch
from
6e5e5aa to
a3be1d7
Compare
wchan2
force-pushed
the
refactor-to-decouple-kinesis-and-the-client
branch
2 times, most recently
from
8f81335 to
97162a0
Compare
wchan2
force-pushed
the
refactor-to-decouple-kinesis-and-the-client
branch
from
97162a0 to
b7797bc
Compare
|
Hey @le0pard , This is finally ready! I finally had the time to test this with Kinesis and read off records just fine. There is another small aesthetic change which are the naming of the contents using the effective Go way (camel-casing and capitalizing if its going to be exported). |
le0pard
added a commit
that referenced
this pull request
Jun 10, 2015
…he-client Refactor to decouple kinesis and the client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @le0pard ,
Here is the other refactor for decoupling out the construction of the client. Please don't merge this yet. I am hoping to manually test that this refactor and the previous refactor works. I'll let you know when this is ready :). Thanks again!