Improve error message when JSON messages r empty #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can mess up some downstream logging systems.
| @@ -119,14 +120,18 @@ type jsonErrors struct { | |||
| } | |||
|
|
|||
| func buildError(r *http.Response) error { | |||
| // Reading the body into a []byte because we might need to put it into an error | |||
| // message after having the JSON decoding fail to produce a message. | |||
| body, _ := ioutil.ReadAll(r.Body) | |||
There was a problem hiding this comment.
Hello. I think we should not ignore ioutil.ReadAll error and also handle it. What do you think?
There was a problem hiding this comment.
Agreed. Check out 24f309d. How’s that look?
le0pard
added a commit
that referenced
this pull request
Apr 1, 2015
Improve error message when JSON messages r empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refines a change I made in e77cc7e.