Code should be run through go fmt.

[benwilson512]

I was preparing a patch to fix a bug when encoding records for kinesis, and noticed that you're using spaces for indentation instead of tabs, which indicates that Go FMT isn't being used on the code. This complicates patch writing when many editors automatically go-fmt code on saving, causing substantial diffs as most lines are re-written to use tabs, or are otherwise restructured to follow go-fmt styles.

See http://blog.golang.org/go-fmt-your-code

[le0pard]

We are using Go FMT: gofmt -tabs=false -tabwidth=2 -l -w *.go

[benwilson512]

Fair, and as the project writers it's entirely your prerogative to pick a standard, but when the official word on tabs vs spaces is "We use tabs for indentation and gofmt emits them by default. Use spaces only if you must." (http://golang.org/doc/effective_go.html#formatting) it just seems somewhat counter productive to alter that standard.

I'm sure you have your reasons, I just wanted to make sure you knew that it poses a barrier to contributions. Either I use a different editor that doesn't have code completion or run go fmt automatically, or I modify the go fmt script run by the Go plugin for Sublime Text to do spaces, but then it now conflicts with other projects I have open, or I run gofmt -tabs=false -tabwidth=2 -l -w *.go prior to doing any git diff checks. None of those are great options.

[le0pard]

Fixed.

[benwilson512]

Thanks!