Skip to content

docs: Add code reviews to CONTRIBUTING.md #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dagjaneiro
Copy link
Contributor

@dagjaneiro dagjaneiro commented Oct 31, 2017

Closes #73

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added necessary documentation about the functionality in the appropriate .md file

Short description of what this PR does:

  • Adds code review contributing guidelines

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 31, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 31, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ dagjaneiro
❌ thinkingserious
You have signed the CLA already but the status is still pending? Let us recheck it.

@dagjaneiro dagjaneiro force-pushed the add-code-reviews-to-contributing branch from 118df45 to 52e78f0 Compare October 31, 2017 19:59
@dagjaneiro dagjaneiro force-pushed the add-code-reviews-to-contributing branch from 52e78f0 to 7fe531d Compare October 31, 2017 20:11
@thinkingserious
Copy link
Contributor

@dagjaneiro

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code labels Mar 6, 2018
Copy link

@jonjenkins jonjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@jonjenkins jonjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonjenkins jonjenkins added hacktoberfest status: ready for deploy code ready to be released in next deploy and removed status: code review request requesting a community code review or review from Twilio hacktoberfest labels Oct 22, 2018
@thinkingserious thinkingserious merged commit 6e8d1d1 into sendgrid:master Oct 29, 2018
@thinkingserious
Copy link
Contributor

Hello @dagjaneiro,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@childish-sambino childish-sambino changed the title Add code reviews to CONTRIBUTING.md docs: Add code reviews to CONTRIBUTING.md Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: docs update documentation change not affecting the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Code Review to Contributing.md
5 participants