Skip to content

feat: added datetimeoffset support to send_at #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2021
Merged

feat: added datetimeoffset support to send_at #106

merged 1 commit into from
Mar 11, 2021

Conversation

@LouisWhite15
Copy link
Contributor

@LouisWhite15 LouisWhite15 commented Mar 8, 2021 •
edited
Loading

Fixes

Adds support for DateTimeOffset's to the SetSendAt methods so that users can specify which timezone they wish to send their emails on.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Mar 8, 2021
@LouisWhite15 LouisWhite15 force-pushed the sendat_datetimeoffset branch from a4b7590 to 9c060e4 Compare March 8, 2021 07:43
shwetha-manvinkurke
shwetha-manvinkurke reviewed Mar 10, 2021
View reviewed changes
@LouisWhite15 LouisWhite15 force-pushed the sendat_datetimeoffset branch from 9c060e4 to 098e7ef Compare March 11, 2021 00:04
@LouisWhite15
Copy link
Contributor Author

LouisWhite15 commented Mar 11, 2021 •
edited
Loading

@shwetha-manvinkurke Implemented code review feedback and squashed into the same commit for a clean commit history

shwetha-manvinkurke
shwetha-manvinkurke approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@shwetha-manvinkurke shwetha-manvinkurke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the contribution!

@shwetha-manvinkurke shwetha-manvinkurke merged commit 0fd85a3 into sendgrid:main Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shwetha-manvinkurke shwetha-manvinkurke shwetha-manvinkurke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: code review request requesting a community code review or review from Twilio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LouisWhite15 @shwetha-manvinkurke @thinkingserious