Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#692 multi line codes in <pre> turn to one line after mail send. #765

Closed
wants to merge 2 commits into from
Closed

#692 multi line codes in <pre> turn to one line after mail send. #765

wants to merge 2 commits into from

Conversation

ssiddhantsharma
Copy link
Contributor

@ssiddhantsharma ssiddhantsharma commented Oct 3, 2018 •
edited by thinkingserious
Loading

Fixes

Fixes #692

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Made changes with several cases of 
     tags to support line wrap.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 3, 2018
@SendGridDX
Copy link
Collaborator

SendGridDX commented Oct 3, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious added the difficulty: easy fix is easy in difficulty label Oct 5, 2018
@thinkingserious
Copy link
Contributor

Hi @ssiddhantsharma,

Could you please move this content here.

Thank you!

With Best Regards,

Elmer

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap hacktoberfest difficulty: medium fix is medium in difficulty status: waiting for feedback waiting for feedback from the submitter and removed difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio labels Oct 5, 2018
@thinkingserious
Copy link
Contributor

Hello @ssiddhantsharma,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

ssiddhantsharma added a commit to ssiddhantsharma/sendgrid-nodejs that referenced this pull request Oct 7, 2018
@ssiddhantsharma @thinkingserious
sendgrid#765 - Updating the troubleshooting.md
bae6f26 
Added the sendgrid#692 multi line codes in <pre> turn to one line after mail send,
to the troubleshooting.md on your request.

Co-Authored-By: Elmer Thomas <elmer@thinkingserious.com>
@ssiddhantsharma
Copy link
Contributor Author

@thinkingserious Updated the troubleshoot file with your request.
#785

@reedsa
Copy link
Contributor

reedsa commented Oct 12, 2018

Thank you for the update! It looks like we can close this PR and move #785 forward.

@ssiddhantsharma
Copy link
Contributor Author

@reedsa I am working on an updating #785, but yes we should close this one.

@reedsa reedsa closed this Oct 15, 2018
thinkingserious added a commit that referenced this pull request Oct 22, 2018
@thinkingserious
Merge pull request #785 from ssiddhantsharma/ssiddhant-1
c445f1d 
#765 - Updating the troubleshooting.md
@ssiddhantsharma ssiddhantsharma deleted the siddhantsharma-1 branch October 23, 2018 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: waiting for feedback waiting for feedback from the submitter type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

multi line codes in <pre> turn to one line after mail send.
4 participants
@ssiddhantsharma @SendGridDX @thinkingserious @reedsa