Skip to content

Exclude sections from camel/snake case conversion in Mail helper class #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2018

Conversation

simonbelanger
Copy link
Contributor

No description provided.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label May 23, 2018
@SendGridDX
Copy link
Collaborator

SendGridDX commented May 23, 2018

CLA assistant check
All committers have signed the CLA.

@thinkingserious
Copy link
Contributor

Thanks @simonbelanger!

How did you figure out sections should be excluded?

@simonbelanger
Copy link
Contributor Author

It wasn't working so I took a look at the payload sent to the API by the package and saw that the sections delimiters were all messed up.

@thinkingserious
Copy link
Contributor

Nice! Thanks!

@adamreisnz LGTM. LGTY? Happy Friday!

@adamreisnz
Copy link
Contributor

Awesome, thanks for checking and fixing this!

@thinkingserious thinkingserious added status: ready for deploy code ready to be released in next deploy and removed status: code review request requesting a community code review or review from Twilio labels May 30, 2018
@simonbelanger
Copy link
Contributor Author

Do you have an ETA for the deployment of this fix?

@thinkingserious
Copy link
Contributor

I don't have an ETA just yet, but additional +1's and comments do help issues gain priority in our backlog.

@adamreisnz
Copy link
Contributor

@thinkingserious this can probably be merged safely, as it's essentially a bug fix, for a patch release.

@thinkingserious
Copy link
Contributor

Thanks @adamreisnz! I've got this on the backlog for a release.

@thinkingserious thinkingserious merged commit 3eb2496 into sendgrid:master Jun 14, 2018
@thinkingserious
Copy link
Contributor

Hello @simonbelanger,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@simonbelanger
Copy link
Contributor Author

@thinkingserious My pleasure! Form filled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready for deploy code ready to be released in next deploy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants