Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped the moment, chai-as-promised, and dirty-chai version in package.json #665

Closed
wants to merge 3 commits into from

Conversation

ctrimm
Copy link
Contributor

@ctrimm ctrimm commented Mar 11, 2018

Fixes

Fixes #662.

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar) - Done
  • I have read the [Contribution Guide] and my PR follows them. - Done
  • I updated my branch with the master branch. - Done
  • I have added tests that prove my fix is effective or that my feature works - No need for this
  • I have added necessary documentation about the functionality in the appropriate .md file - No need for this
  • I have added in line documentation to the code I modified - No need for this

Short description of what this PR does:

  • This PR updates the version of moment in order to avoid the potential security vulnerability that exists in versions < 2.19.3
  • While updating this dependency, I also had to update chai-as-promised and dirty-chai

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Mar 11, 2018
@SendGridDX
Copy link
Collaborator

SendGridDX commented Mar 11, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Cory Trimm seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ctrimm ctrimm closed this Mar 11, 2018
@ctrimm
Copy link
Contributor Author

ctrimm commented Mar 11, 2018

Going to retry so there aren't so many commits... Had to set github back up on my personal dev machine...

@ctrimm ctrimm deleted the bug-moment-version-fix branch March 11, 2018 16:38
@thinkingserious
Copy link
Contributor

Thanks @ctrimm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repair potential security vulnerability - moment package
3 participants