Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add links to CONTRIBUTING.md #584

Closed
wants to merge 1 commit into from
Closed

add links to CONTRIBUTING.md #584

wants to merge 1 commit into from

Conversation

thepriefy
Copy link
Contributor

@thepriefy thepriefy commented Oct 31, 2017 •
edited
Loading

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • add links to CONTRIBUTING.md

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 31, 2017
jstevans added a commit to jstevans/sendgrid-nodejs that referenced this pull request Nov 1, 2017
@jstevans
Add links to CONTRIBUTING.MD
e8682c9 
Per issue sendgrid#584, this PR adds links to CONTRIBUTING.MD for easier
navigation.
@jstevans jstevans mentioned this pull request Nov 1, 2017
Merged
6 tasks
clee
clee reviewed Feb 27, 2018
View reviewed changes
Copy link

@clee clee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clee clee added status: code review complete and removed status: code review request requesting a community code review or review from Twilio labels Feb 27, 2018
@clee clee mentioned this pull request Feb 27, 2018
Closed
6 tasks
@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code status: ready for deploy code ready to be released in next deploy and removed status: code review complete labels Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clee clee clee left review comments

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: docs update documentation change not affecting the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thepriefy @clee @thinkingserious @mbernier