Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo #407

Merged
merged 85 commits into from
Aug 28, 2017
Merged

Monorepo #407

merged 85 commits into from
Aug 28, 2017

Conversation

adamreisnz
Copy link
Contributor

@adamreisnz adamreisnz commented Jul 19, 2017

@thinkingserious PR from monorepo to master

@thinkingserious
Copy link
Contributor

@adamreisnz

I can't seem to get the following to work:

const client = require('@sendgrid/client');
client.setApiKey(process.env.SENDGRID_API_KEY);
const data = [
  "127.0.0.1"
];
const request = {
  method: 'PUT',
  body: data,
  url: '/v3/subusers/test_subuser_name/ips'
};
client.request(request)
.then(([response, body]) => {
    console.log(response.statusCode);
    console.log(response.body);
})

because the payload that gets sent is:

{
  "0": "127.0.0.1"
}

Here is how it worked before: https://github.com/sendgrid/sendgrid-nodejs/blob/master/test/test.js#L4137

Any ideas?

@adamreisnz
Copy link
Contributor Author

@thinkingserious There was an issue with the merge data helper, I've fixed this in 3be7fd8

@thinkingserious
Copy link
Contributor

I'm not quite sure why those final two tests are failing. Locally, they work fine. I'll dig deeper.

@thinkingserious thinkingserious merged commit dad53e8 into sendgrid:master Aug 28, 2017
@adamreisnz
Copy link
Contributor Author

Awesome thanks for the release! Look forward to ongoing developments of this package.
Did you deprecate the old package on npm?

@thinkingserious
Copy link
Contributor

@adamreisnz,

I did not, but now I have :)

Thanks for the heads up!

@thinkingserious
Copy link
Contributor

Hello @adamreisnz,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@adamreisnz
Copy link
Contributor Author

You're welcome! Glad I could help out.

@adamreisnz adamreisnz deleted the monorepo branch August 31, 2017 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants