-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TypeDefinition] SendGrid.API should return Promise<T> instead of PromiseLike<T> #333
Conversation
👍 Looks good to me |
Hello @IOAyman! Thanks for the PR, great work :) Could you please sign our CLA so that we can merge it? |
@thinkingserious I sent an email on Nov.11.2016 asking a question but no response. |
My apologies, looks like I sent it to the wrong email address (facepalm) I have now forwarded my response. |
Hey folks! Running into this issue myself. Hopefully y'all are emailing back and forth to get this merged.
|
Hi @ksiegel, This one is still climbing up our backlog. I've now added your vote to bump it up further, thanks! |
Very much appreciated, thank you 🎆 😄 |
Issue Summary
I think the SendGrid.API function should return a object on which either
.then()
or.catch()
can be called upon.The current implementation uses PromiseLike interface which only ensures
.then()
.But the problem would be solved by using Promise interface instead.
Demo
Technical details:
This references #308
/cc @spartan563