feat: Added support of replyToList in the library, #339: #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to f/replyToMultiple
Added support of replyToList in the library
- Use the replyToList header to set multiple emailIds in the reply-to section of an email - Fixed old test cases that were failing as SendGrid changed the acceptable response code to 202
shwetha-manvinkurke
changed the title
- removed commented unused code - Fixed typo in error message string - added missing test cases - added example doc of replyToLIst in use-cases
…to feature/replyToListImplementation
packages/mail/src/mail.spec.js
Outdated
| @@ -38,12 +38,12 @@ describe('sgMail.send()', () => { | |||
| return expect(sgMail.send()).to.eventually.be.rejectedWith(Error); | |||
| }); | |||
|
|
|||
| it('should send a basic email', () => { | |||
| sgClient.setDefaultHeader('X-Mock', 201); | |||
| it('should send a basic email', async () => { | |||
There was a problem hiding this comment.
Doesn't look like async is supported in node 6/8 which we still support
There was a problem hiding this comment.
sure, will look into it and do the required changes
There was a problem hiding this comment.
@shwetha-manvinkurke - I removed the use of async in the test case as you suggested
shwetha-manvinkurke
approved these changes
Oct 15, 2021
This was referenced Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #339
Fixes #1301
The replyToList support was added in v3 API but it wasn't supported in the library. With this changes, we can:
emailparameter and may also contain a name parameter.Acceptable Format:
[ { "name": "Test Team", "email": "test@example.org" }, { "name": "Support Test Team", "email": "support.test@example.org" } ]or
[ { "email": "test@example.org" }, { "name": "Support Test Team", "email": "support.test@example.org" } ]