Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: export type MailDataRequired #1053

Merged
merged 4 commits into from
Mar 5, 2020

Conversation

antonsamper
Copy link

Exposes the new mail properties type MailDataRequired that was added in #1041

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the master branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Mar 5, 2020
@childish-sambino
Copy link
Contributor

@antonsamper Thoughts on test failure?

packages/mail/src/mail.d.ts:36:1 - error TS2309: An export assignment cannot be used in a module with other exported elements.

@antonsamper
Copy link
Author

@childish-sambino looking into it now.
I'm going to move the type declaration to @sendgrid/helpers/classes/mail along with the others and will export it from there.

@childish-sambino
Copy link
Contributor

@antonsamper Make sense to me. Can you merge in this change as well? #1054

@FelixLeChat
Copy link

Is there an ETA for a release containing this fix ?

@childish-sambino
Copy link
Contributor

Next release is scheduled for 2020-03-18.

@rubenheymans
Copy link

rubenheymans commented Mar 8, 2020

What is the temp fix though?

@childish-sambino
Copy link
Contributor

@rubenheymans Temp fix is to pin to the 6.5.3 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants