Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validate API key is non-empty #924

Merged
merged 5 commits into from
Apr 9, 2020
Merged

fix: validate API key is non-empty #924

merged 5 commits into from
Apr 9, 2020

Conversation

aevitas
Copy link
Contributor

@aevitas aevitas commented Aug 24, 2019 •
edited
Loading

Fixes #923

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the development branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Ensures provided SendGridClientOptions are valid enough to work with

Pending tests - I'll add those shortly.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Aug 24, 2019
@aevitas
Copy link
Contributor Author

aevitas commented Sep 6, 2019

Updated based on @akunzai 's suggestions

@akunzai
Copy link
Contributor

akunzai commented Sep 6, 2019

Hi @aevitas ,

It is recommended change the title prefix with WIP: before the pending tests fixed.

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: bug bug in the library labels Sep 6, 2019
@aevitas aevitas changed the title Options validation WIP: Options validation Sep 19, 2019
This was referenced Oct 9, 2019
Closed
Closed
@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap and removed type: bug bug in the library labels Oct 9, 2019
@aevitas
Copy link
Contributor Author

aevitas commented Oct 9, 2019

@thinkingserious I see you removed the bug label, but this is an actual bug. :)

@childish-sambino childish-sambino added type: bug bug in the library and removed type: community enhancement feature request not on Twilio's roadmap labels Apr 9, 2020
childish-sambino
childish-sambino approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@childish-sambino childish-sambino changed the title WIP: Options validation fix: validate API key is non-empty Apr 9, 2020
@childish-sambino childish-sambino merged commit 278735c into sendgrid:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akunzai akunzai akunzai left review comments

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: bug bug in the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SendGridClient should be created if there's no valid key
4 participants
@aevitas @akunzai @childish-sambino @thinkingserious