Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mixup of Response.Body and Response.Header summaries #688

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Fix mixup of Response.Body and Response.Header summaries #688

merged 1 commit into from
Aug 21, 2018

Conversation

rsheasby
Copy link
Contributor

@rsheasby rsheasby commented Apr 25, 2018 •
edited
Loading

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • There is a mixup in the inline documentation of the Response object. The summary for Response.Body says it's for the header and visa versa. This PR will fix that.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Apr 25, 2018
@SendGridDX
Copy link

SendGridDX commented Apr 25, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@thinkingserious
Copy link
Contributor

Thanks @ryan27968! This is now on our backlog for merge.

@jpurpura jpurpura added difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: twilio enhancement feature request on Twilio's roadmap and removed status: code review request requesting a community code review or review from Twilio labels Aug 13, 2018
@thinkingserious thinkingserious merged commit b63ba3b into sendgrid:master Aug 21, 2018
@thinkingserious
Copy link
Contributor

Hello @ryan27968,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rsheasby @SendGridDX @thinkingserious @jpurpura