Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected list all recipients documentation Fixes #351 #527

Merged
merged 1 commit into from
Oct 22, 2017

Conversation

Gimly
Copy link
Contributor

@Gimly Gimly commented Sep 30, 2017

Fixed the example query for list all recipients to be the same as the one in SendGrid's documentation. Removed the list_id parameter that was incorrect.

Fixes #351

Fixed the example query for list all recipients to be the same as the one in SendGrid's documentation. Removed the list_id parameter that was incorrect.

Fixes sendgrid#351
@SendGridDX
Copy link

SendGridDX commented Sep 30, 2017

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty hacktoberfest status: code review request requesting a community code review or review from Twilio labels Sep 30, 2017
@mbernier
Copy link
Contributor

@Gimly did you find that the list_id param was not actually the issue, but the page size was the issue?

The original page size being 1 doesn't make sense, I just want to verify that I am following your change here.

@mbernier mbernier merged commit 53b042a into sendgrid:master Oct 22, 2017
@thinkingserious
Copy link
Contributor

Hello @Gimly,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@Gimly
Copy link
Contributor Author

Gimly commented Oct 22, 2017

@mbernier Yes, list_id didn't make sense in that call so I removed it, that fixed the issue. And since I was modifying the doc for that,I thought it would make sense that it was the same as the Sendgrid api. That's why I also modified the page_size.

@Gimly Gimly deleted the 351-FixRetrieveAllRecipientsDoc branch October 22, 2017 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants