Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use httpErrorAsException when passed as parameter to SendGridClient constructor #1180

Merged

Conversation

mortenbock
Copy link
Contributor

Fixes

When passing httpErrorAsException as a parameter to the SendGridClient constructor, it was not used for anything. This PR passes the value the the options object created.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

@mortenbock mortenbock changed the title Use httpErrorAsException when passed as parameter to SendGridClient constructor fix: Use httpErrorAsException when passed as parameter to SendGridClient constructor Jul 28, 2022
@mortenbock
Copy link
Contributor Author

Well that's awkward. Apparently I did not run a compile before pushing. But I think this would result in the same issue as when the optional parameter was added?

I'm not sure what the best approach is here. I could change the order of the optional parameters maybe for the new overload?

@mortenbock mortenbock force-pushed the fix/use-constructor-parameter branch from 7d1868e to f3b7004 Compare July 28, 2022 20:04
@mortenbock
Copy link
Contributor Author

I changed the overload to avoid conflicting signatures.

Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 Thanks for the fix!

@childish-sambino childish-sambino merged commit 8d1e10a into sendgrid:main Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants