-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not introduce breaking changes in minor versions #1000
Comments
So this is the old line:
It uses
How were you able to modify the |
ReliabilitySettings gets broken in this commit: |
Ahhh, perfect. Thanks! So it's been broken since And just to be clear, you're basically wanting this constructor back so you can pass in your own sendgrid-csharp/src/SendGrid/SendGridClient.cs Lines 68 to 76 in 2310b6e
|
… its reliability settings Fixes #1000 Relates to #839 When the default client options were made static and the constructor was removed, there was no way to modify the reliability settings used by the retry handler. This fix adds back the constructor so clients can now be constructed with just the client options and the options will be used when creating a retry handled, if any.
… its reliability settings Fixes #1000 Relates to #839 When the default client options were made static and the constructor was removed, there was no way to modify the reliability settings used by the retry handler. This fix adds back the constructor so clients can now be constructed with just the client options and the options will be used when creating a retry handler, if any.
…e its reliability settings Fixes #1000 Relates to #839 When the default client options were made static and the constructors later removed, there was no way to modify the reliability settings used by the retry handler. This fix adds back the constructors so clients can now be constructed with just the client options and the options will be used when creating a retry handler, if any.
…e its reliability settings Fixes #1000 Relates to #839 When the default client options were made static and the constructors later removed, there was no way to modify the reliability settings used by the retry handler. This fix adds back the constructors so clients can now be constructed with just the client options and the options will be used when creating a retry handler, if any.
…e its reliability settings (#1001) Fixes #1000 Relates to #839 When the default client options were made static and the constructors later removed, there was no way to modify the reliability settings used by the retry handler. This fix adds back the constructors so clients can now be constructed with just the client options and the options will be used when creating a retry handler, if any.
Issue Summary
Version 9.15.0 contains undocumented breaking changes in SendGridCient. Now it is impossible to pass own configuration using SendGridClientOptions. Because of this it is impossible to set some of options avaiable in SendGridClientOptions (for example ReliabilitySettings).
And now I discovered that ReliabilitySettings is totaly ignored (it is hardcoded):
sendgrid-csharp/src/SendGrid/BaseClient.cs
Line 226 in cf61849
sendgrid-csharp/src/SendGrid/BaseClient.cs
Line 245 in cf61849
This is shame. Your developers should really think about changes that they make (merget to master branch) before you publish new version. You are breaking existing code.
The text was updated successfully, but these errors were encountered: