Skip to content

Do not introduce breaking changes in minor versions #1000

Closed
@janousek

Description

@janousek

Issue Summary

Version 9.15.0 contains undocumented breaking changes in SendGridCient. Now it is impossible to pass own configuration using SendGridClientOptions. Because of this it is impossible to set some of options avaiable in SendGridClientOptions (for example ReliabilitySettings).

And now I discovered that ReliabilitySettings is totaly ignored (it is hardcoded):

return new HttpClient(new RetryDelegatingHandler(new ReliabilitySettings()));

var retryHandler = new RetryDelegatingHandler(httpClientHandler, new ReliabilitySettings());

This is shame. Your developers should really think about changes that they make (merget to master branch) before you publish new version. You are breaking existing code.

Metadata

Metadata

Assignees

No one assigned

    Labels

    status: work in progressTwilio or the community is in the process of implementingtype: bugbug in the library

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions