-
Notifications
You must be signed in to change notification settings - Fork 583
Closed
Labels
status: work in progressTwilio or the community is in the process of implementingTwilio or the community is in the process of implementingtype: bugbug in the librarybug in the library
Description
Issue Summary
Version 9.15.0 contains undocumented breaking changes in SendGridCient. Now it is impossible to pass own configuration using SendGridClientOptions. Because of this it is impossible to set some of options avaiable in SendGridClientOptions (for example ReliabilitySettings).
And now I discovered that ReliabilitySettings is totaly ignored (it is hardcoded):
sendgrid-csharp/src/SendGrid/BaseClient.cs
Line 226 in cf61849
return new HttpClient(new RetryDelegatingHandler(new ReliabilitySettings())); |
sendgrid-csharp/src/SendGrid/BaseClient.cs
Line 245 in cf61849
var retryHandler = new RetryDelegatingHandler(httpClientHandler, new ReliabilitySettings()); |
This is shame. Your developers should really think about changes that they make (merget to master branch) before you publish new version. You are breaking existing code.
Metadata
Metadata
Assignees
Labels
status: work in progressTwilio or the community is in the process of implementingTwilio or the community is in the process of implementingtype: bugbug in the librarybug in the library