Check coding style violations in CI

[tachyons]

Fixes #81

Checklist

• I have made a material change to the repo (functionality, testing, spelling, grammar)
• I have read the [Contribution Guide] and my PR follows them.
• I updated my branch with the master branch.
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation about the functionality in the appropriate .md file
• I have added inline documentation to the code I modified

Short description of what this PR does:

• Add minitest and rubocop in gem dev dependencies
• Run rubocop in the CI
• Fixed rubocop violations using --autocorrect

[SendGridDX]

All committers have signed the CLA.

[tachyons]

Seems like #80 already addressed this! Closing mine

[kplimack]

@tachyons Thank you for your contribution! My PR isn't passing, would you like to team on on turning it green and getting it merged?

[tachyons]

lib/ruby_http_client.rb:41:19: C: Metrics/ParameterLists: Avoid parameter lists longer than 5 parameters. [6/5]
    def initialize(host: nil, request_headers: nil, version: nil, url_path: nil, http_options: {}, proxy_options: {})
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
7 files inspected, 1 offense detected
rake aborted!

Just add

def initialize(host: nil, request_headers: nil, version: nil, url_path: nil, http_options: {}, proxy_options: {}) # rubocop:disable Metrics/ParameterLists
...
end

@kplimack

[kplimack]

@tachyons does that work as a one liner or do I need to explicitly re-enable that cop after the method definition ?

[tachyons]

Yes, that one-liner is enough. No need to re-enable it explicitly

[thinkingserious]

Hello @tachyons,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

[thinkingserious]

Hello @tachyons,

Thanks again for the PR!

We noticed that you have earned 3 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold.

Also, please be sure that you have officially registered here.

Thank you and Happy Hacktobering!

Team SendGrid DX

[thinkingserious]

Hello @tachyons,

Thanks again for the PR!

You have earned 3 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at dx+hacktoberfest2018@sendgrid.com.

Thank you and Happy Hacktobering!

Team SendGrid