Add Code Review to Contributing.md #63 #64
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkingserious
added
the
status: code review request
|
|
thinkingserious
added
difficulty: easy
kplimack
approved these changes
Oct 19, 2018
kplimack
suggested changes
Oct 19, 2018
| @@ -190,5 +191,8 @@ Please run your code through: | |||
|
|
|||
| 7. [Open a Pull Request](https://help.github.com/articles/using-pull-requests/) | |||
| with a clear title and description against the `master` branch. All tests must be passing before we will review the PR. | |||
|
|
|||
| ## Code Reviews<a name="code-reviews"></a> | |||
There was a problem hiding this comment.
you do not need to insert an HTML anchor tag, github makes anchors automatically for every heading you make, inserting dashes in lieu of spaces
There was a problem hiding this comment.
the link would look like:
[Code Reviews](#code-reviews)
so that doesnt change.
|
Duplicates #100 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63
Checklist
Short description of what this PR does:
If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.