feat: Add option to set http attributes when creating an instance of Client #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkingserious
added
the
status: code review request
Closed
mbernier
suggested changes
Oct 11, 2017
| @@ -31,9 +31,11 @@ def setup | |||
| ') | |||
| @host = 'http://localhost:4010' | |||
| @version = 'v3' | |||
There was a problem hiding this comment.
@jrectenwald Would you be OK with adding a duplicate test to this one, that doesn't pass http_options, so we can prove in the tests that it works both ways?
There was a problem hiding this comment.
@mbernier How's that?
thinkingserious
added
difficulty: medium
|
Hello @jrectenwald, |
|
|
Closed
thinkingserious
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is addressing issue #13
The Problem
The issue requests the ability to override the Net::HTTP defaults for open and read timeouts.
What I did
I added a parameter called http_options to the Sendgrid::Client class. This parameter should be a hash with key/value pairs corresponding with attributes for NET:HTTP as described here. I added this in the test file and added this to the example file as well.