Skip to content

feat: Adding Docker support #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 13, 2017
Merged

feat: Adding Docker support #67

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b1a04ab
Adding Docker support.
mithunsasidharan Oct 29, 2017
9a556ed
Adding Docker support.
mithunsasidharan Oct 29, 2017
d89934e
Merge pull request #1 from sendgrid/master
mithunsasidharan Nov 13, 2017
f9508e5
Added docker support
mithunsasidharan Nov 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Added docker support
  • Loading branch information
@mithunsasidharan
mithunsasidharan committed Nov 13, 2017
commit f9508e5de6abb0bf9f99e9f70b0f3ee77d9e69ba
5 changes: 4 additions & 1 deletion docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,20 @@ WORKDIR /root

# install Prism
ADD https://raw.githubusercontent.com/stoplightio/prism/master/install.sh install.sh
RUN chmod +x ./install.sh && \
RUN chmod +x ./install.sh && sync && \
./install.sh && \
rm ./install.sh

# set up default sendgrid env
WORKDIR /root/sources
RUN git clone https://github.com/sendgrid/java-http-client.git

WORKDIR /root
RUN ln -s /root/sources/java-http-client/sendgrid

COPY entrypoint.sh entrypoint.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that there is an issue with the path here, I got the following error:

Removing intermediate container ffe1fcef3a69
Step 11/14 : COPY entrypoint.sh entrypoint.sh
COPY failed: stat /var/lib/docker/tmp/docker-builder064488478/entrypoint.sh: no such file or directory

RUN chmod +x entrypoint.sh

# Set entrypoint
ENTRYPOINT ["./entrypoint.sh"]
CMD ["--mock"]
2 changes: 1 addition & 1 deletion src/test/java/com/sendgrid/TestRequiredFilesExist.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ public class TestRequiredFilesExist {

// ./Docker or docker/Docker
@Test public void checkDockerExists() {
boolean dockerExists = new File("./Docker").exists() ||
boolean dockerExists = new File("./docker/Dockerfile").exists() ||
new File("./docker/Docker").exists();
assertTrue(dockerExists);
}
Expand Down