remove COMMAND GETKEYS call from ZUNION and ZUNIONSTORE
#4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4 +/- ##
==========================================
- Coverage 92.36% 92.35% -0.01%
==========================================
Files 119 119
Lines 30600 30615 +15
==========================================
+ Hits 28265 28276 +11
- Misses 2335 2339 +4
☔ View full report in Codecov by Sentry. |
zach-iee
force-pushed
the
zach/remove_command_getkeys
branch
2 times, most recently
from
d47dbe7 to
82ec943
Compare
zach-iee
changed the title
COMMAND GETKEYS call from ZUNION and ZUNIONSTORECOMMAND GETKEYS call from ZUNION and ZUNIONSTORE
zach-iee
force-pushed
the
zach/remove_command_getkeys
branch
from
82ec943 to
4b228cf
Compare
bellatoris
reviewed
Jul 4, 2023
| @@ -968,6 +968,14 @@ def determine_slot(self, *args): | |||
| if len(eval_keys) == 0: | |||
| return random.randrange(0, REDIS_CLUSTER_HASH_SLOTS) | |||
| keys = eval_keys | |||
| elif command == "ZUNIONSTORE": | |||
There was a problem hiding this comment.
georadius
georadiusbymember
migrate
sort
sort_ro
zdiffstore
zinterstore
shouldn't we raise an exception for above commands?
There was a problem hiding this comment.
I assume that we are not using those commands, but just in case.
There was a problem hiding this comment.
yeap, i'm trying to block those commands in soda code, let me write the PR link once it's ready
There was a problem hiding this comment.
got it, please be careful that we should block direct call like execute_command(sort)
There was a problem hiding this comment.
bellatoris
approved these changes
Jul 4, 2023
zach-iee
added a commit
that referenced
this pull request
Jul 4, 2023
* make EVALSHA and EVALSHA_RO to avoid command_keys as well * make ZUNION, ZUNIONSTORE to avoid command_keys as well
zach-iee
added a commit
that referenced
this pull request
Jul 4, 2023
* make EVALSHA and EVALSHA_RO to avoid command_keys as well * make ZUNION, ZUNIONSTORE to avoid command_keys as well
zach-iee
added a commit
that referenced
this pull request
Jul 7, 2023
* make EVALSHA and EVALSHA_RO to avoid command_keys as well * make ZUNION, ZUNIONSTORE to avoid command_keys as well
zach-iee
added a commit
that referenced
this pull request
Aug 21, 2023
* make EVALSHA and EVALSHA_RO to avoid command_keys as well * make ZUNION, ZUNIONSTORE to avoid command_keys as well
zach-iee
added a commit
that referenced
this pull request
Aug 21, 2023
* make EVALSHA and EVALSHA_RO to avoid command_keys as well * make ZUNION, ZUNIONSTORE to avoid command_keys as well
zach-iee
added a commit
that referenced
this pull request
Sep 14, 2023
* make EVALSHA and EVALSHA_RO to avoid command_keys as well * make ZUNION, ZUNIONSTORE to avoid command_keys as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
$ toxpass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Redis 7 has a bug, which causes the server to crash with large size of keys in
COMMAND GETKEYSredis/redis#12380
In order for us to execute
ZUNIONSTOREwithout a crash, this PR manually extracts keys from theZUNIONSTOREwithout callingCOMMAND GETKEYS