Skip to content

Cherry pick sharded pubsub commit into 4.4 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2023

Conversation

noah-chae
Copy link

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@noah-chae noah-chae requested a review from zach-iee July 28, 2023 06:49
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2023

Codecov Report

Patch coverage: 27.13% and project coverage change: -0.45% ⚠️

Comparison is base (e85e3f7) 60.59% compared to head (240ee07) 60.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.4      #10      +/-   ##
==========================================
- Coverage   60.59%   60.14%   -0.45%     
==========================================
  Files         116      116              
  Lines       29922    30242     +320     
==========================================
+ Hits        18130    18189      +59     
- Misses      11792    12053     +261     
Files Changed Coverage Δ
tests/test_asyncio/test_pubsub.py 20.99% <ø> (ø)
redis/cluster.py 85.27% <15.71%> (-5.59%) ⬇️
tests/test_pubsub.py 57.22% <27.52%> (-15.60%) ⬇️
redis/client.py 67.87% <37.20%> (-1.76%) ⬇️
redis/commands/core.py 78.12% <50.00%> (-0.10%) ⬇️
redis/commands/parser.py 63.33% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@zach-iee zach-iee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noah-chae i think most of the codes are from existing redis-py master branch except for the push_handler_func. Am i correct?

@noah-chae
Copy link
Author

@zach-iee That's right. It's just a cherry-pick & resolve merge conflict commit. But I don't know about push_handler_func 😲

@noah-chae noah-chae merged commit 1f75b91 into 4.4 Jul 30, 2023
@zach-iee zach-iee deleted the 4.4-cherry-pick-sharded-pubsub branch August 24, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants