This repository has been archived by the owner on Jan 16, 2024. It is now read-only.
New Icon Set #85
Merged
New Icon Set #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
xispa
approved these changes
Jul 10, 2018
There was a problem hiding this comment.
There are some icons that are repeated (e.g. drugs vs. immunizations), but since this is a whole new iconset, I prefer to accept them and change those that might be confusing later, little by little. Thanks @juangallostra !
xispa
added a commit
that referenced
this pull request
Jul 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
Linked issue: #84
This PR adds a complete new icon set to SENAITE HEALTH that matches the new
senaite.coreicon style.Current behavior before PR
Old icons are used
Desired behavior after PR is merged
New icons from https://iconmonstr.com are used for
senaite.health--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.