This repository has been archived by the owner on Jan 16, 2024. It is now read-only.
Allow ReferenceWidgetAdapter to be exclusive #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
ReferenceWidgetAdapterallows to change searches specified in the reference widget on-the-fly. This allows to redefine the search based on current context, on values from other fields, etc. This is mostly used to filter queries by client in different contexts. However, if multipleReferenceWidgetAdaptersare found for a given context, the system calls them sequentially and follows an "additive" approach (brains returned by each adapter are being added).This Pull Request adds the
IExclusiveReferenceWidgetAdapter, so when an adapter of this type is found, the system behaves differently by dismissing the rest of adapters.Current behavior before PR
System always handle brains returned by
ReferenceWidgetAdapterin an "additive" manner.Desired behavior after PR is merged
System can return a subset of brains when an
IExclusiveReferenceWidgetAdapteris used.--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.