This repository has been archived by the owner on Jan 16, 2024. It is now read-only.
Cannot override Patients listing behavior with subscriber adapters #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`PatientsView` is used as the "root" listing view for Patients listings. Since it overrides the function `before_render`, some of the changes made in subscriber adapters from another add-ons are omitted. For instance, trying to modify `self.context_actions` via subscriber adapters won't have any effect because after the call, the value is overrided in PatientsView. This Pull Request moves the logic `before_render` from the base class `PatientsView` to the function `update`.
ramonski
approved these changes
Jan 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
PatientsViewis used as the "root" listing view for Patients listings. Since it overrides the functionbefore_render, some of the changes made in subscriber adapters from another add-ons are omitted. For instance, trying to modifyself.context_actionsvia subscriber adapters won't have any effect because after the call, the value is overrided in PatientsView.This Pull Request moves the logic
before_renderfrom the base classPatientsViewto the functionupdate.Current behavior before PR
Cannot override some behavior (e.g., context_actions) of PatientsView listing by using subscriber adapters.
Desired behavior after PR is merged
Can override behavior of PatientsView listing by using subscriber adapters.
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.