Explicitly set client on sample creation #2240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
requested changes
Jan 26, 2023
|
|
||
| obj = api.get_object(obj) | ||
| field = obj.getField("Client") | ||
| value = field.get(obj) |
There was a problem hiding this comment.
You'll save unnecessary searches against uid_catalog and become faster if you do field.getRaw(obj) instead.
There was a problem hiding this comment.
cool, yes indeed! I'll add it
xispa
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This PR ensures that the
Clientschema field is set properly when creating new samples withcreate_analysisrequest.Current behavior before PR
If the function
create_analysisrequestis called programmatically outside the sample add form, theClientvalue was expected to be passed in with thevalues, instead of using it from the first parameter:As a result, these samples couldn't be copied:
Desired behavior after PR is merged
The client field is explicitly set to the client parameter.
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.