Skip to content

Conversation

ilyabrower
Copy link
Contributor

Motivation and Context

How has this been tested?

Manually

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • I have updated the documentation accordingly.
  • I have added changelog note to corresponding CHANGELOG.md file with planned publish date.
  • I have added new tests on added of fixed functionality.

Copy link
Contributor

@sheila-semrush sheila-semrush Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the pagination one is different, I saw it but decided not to mention it. In that case it's just the property value that doesn't fit, which is rare, and this particular value isn't useful anyway. So I'd not do anything with it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed my snapshot)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because reactElementToJSXString write only one prop to the same line.
I can only set maxLenght for the line (and it will move this property to the next, but then you will see the initial issue.
Let's stay it as is

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilyabrower can't we set maxLength to some bigger value than it was before?

bigger than here:

imagen

but less than here:

imagen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants