Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: add retryable errors to checks #233

Merged
merged 1 commit into from
Aug 19, 2024
Merged

feat!: add retryable errors to checks #233

merged 1 commit into from
Aug 19, 2024

Conversation

gusinacio
Copy link
Collaborator

@gusinacio gusinacio commented Jul 31, 2024 •
edited
Loading

Closes #234

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 10185331760

Details

  • 17 of 41 (41.46%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 81.182%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tap_core/src/manager/tap_manager.rs 3 4 75.0%
tap_core/src/receipt/received_receipt.rs 7 10 70.0%
tap_core/src/receipt/checks.rs 0 8 0.0%
tap_core/src/manager/context/memory.rs 7 19 36.84%
Totals Coverage Status
Change from base Build 9689732858: 0.4%
Covered Lines: 975
Relevant Lines: 1201
💛 - Coveralls

@gusinacio gusinacio force-pushed the gusinacio/check-error-recoverable branch 2 times, most recently from 398e11b to ce4dd19 Compare August 14, 2024 16:46
@gusinacio gusinacio changed the title feat!: add recoverable errors to checks feat!: add retryable errors to checks Aug 16, 2024
@gusinacio gusinacio force-pushed the gusinacio/check-error-recoverable branch 3 times, most recently from e5f07e2 to d54aa9f Compare August 16, 2024 13:26
@gusinacio gusinacio marked this pull request as ready for review August 16, 2024 13:27
@gusinacio gusinacio self-assigned this Aug 16, 2024
@gusinacio
feat!: add retryable errors to checks
51f04cb 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio gusinacio force-pushed the gusinacio/check-error-recoverable branch from d54aa9f to 51f04cb Compare August 19, 2024 17:29
@gusinacio gusinacio merged commit ff856d9 into main Aug 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aasseman aasseman aasseman approved these changes

Assignees

@gusinacio gusinacio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checks failure mode
2 participants
@gusinacio @aasseman