Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Receipts w/ consecutive timestamps failed #127

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Fix: Receipts w/ consecutive timestamps failed #127

merged 2 commits into from
Jul 6, 2023

Conversation

aasseman
Copy link
Contributor

@aasseman aasseman commented Jul 6, 2023

Added a test (that initially failed):

  • Create 20 receipts with consecutive timestamps (eg. 1, 2, 3...)
  • Receive the first 10
  • Create RAV
  • Receive remaining 10
  • Create RAV (w/ previous RAV)
  • Check failed receipts and total expected amount

The fix is self-explanatory.

@aasseman aasseman added the type:bug Something isn't working label Jul 6, 2023
@aasseman aasseman force-pushed the receipts_consecutive_timestamps branch from 24e3ed0 to 8983ac1 Compare July 6, 2023 01:22
@github-actions
Copy link

github-actions bot commented Jul 6, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5470537780

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 84.146%
Totals Coverage Status
Change from base Build 5469084437: 0.01%
Covered Lines: 966
Relevant Lines: 1148
💛 - Coveralls

@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@aasseman aasseman self-assigned this Jul 6, 2023
@aasseman aasseman linked an issue Jul 6, 2023 that may be closed by this pull request
Add tests with consecutively timestamped receipts #110
Closed
@aasseman
test(tap_manager): consecutive timestamps and 2 RAVs
087b748 
Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
@aasseman
fix(tap_manager): receipt auditor min_timestamp set incorrectly
743ac7c 
Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
@aasseman aasseman force-pushed the receipts_consecutive_timestamps branch from 8983ac1 to 743ac7c Compare July 6, 2023 17:27
@aasseman
Copy link
Contributor Author

aasseman commented Jul 6, 2023

Rebased onto latest main

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

🤖 Cargo Audit Report 🤖

(Empty means OK! 👍)

@aasseman aasseman merged commit f26adbe into main Jul 6, 2023
8 checks passed
@aasseman aasseman deleted the receipts_consecutive_timestamps branch July 6, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColePBryan ColePBryan ColePBryan approved these changes

@severiano-sisneros severiano-sisneros Awaiting requested review from severiano-sisneros

@tkornuta-semiotic tkornuta-semiotic Awaiting requested review from tkornuta-semiotic

Assignees

@aasseman aasseman

Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests with consecutively timestamped receipts
2 participants
@aasseman @ColePBryan