Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update x/sys to support go 1.17 #100

Merged
merged 2 commits into from
Aug 20, 2021
Merged

Update x/sys to support go 1.17 #100

merged 2 commits into from
Aug 20, 2021

Conversation

gordonbondon
Copy link
Contributor

@gordonbondon gordonbondon commented Aug 20, 2021

Updating x/sys so that this project supports go 1.17.

More context: Homebrew/homebrew-core#83413

Without this fix running a binary can cause a panic, see upstream go issue: golang/go#45702

Please cut a release after this is merged.

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #100 (8d2a997) into master (fea0fbd) will increase coverage by 0.66%.
The diff coverage is n/a.

❗ Current head 8d2a997 differs from pull request most recent head 24300fc. Consider uploading reports for the commit 24300fc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
+ Coverage   75.72%   76.39%   +0.66%     
==========================================
  Files          40       40              
  Lines        4318     3385     -933     
==========================================
- Hits         3270     2586     -684     
+ Misses        854      605     -249     
  Partials      194      194              
Impacted Files Coverage Δ
middleware/middleware.go 79.16% <0.00%> (-2.86%) ⬇️
dnsutil/dnsutil.go 80.92% <0.00%> (-1.38%) ⬇️
middleware/response_writer.go 90.47% <0.00%> (-1.20%) ⬇️
middleware/hostsfile/hostsfile.go 84.46% <0.00%> (-1.14%) ⬇️
authcache/authserver.go 95.00% <0.00%> (-1.00%) ⬇️
server/server.go 97.29% <0.00%> (-0.67%) ⬇️
middleware/metrics/metrics.go 96.87% <0.00%> (-0.57%) ⬇️
middleware/edns/edns.go 87.69% <0.00%> (-0.55%) ⬇️
authcache/ns_cache.go 85.18% <0.00%> (-0.53%) ⬇️
mock/writer.go 92.68% <0.00%> (-0.50%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fea0fbd...24300fc. Read the comment docs.

@semihalev semihalev merged commit bb09dd0 into semihalev:master Aug 20, 2021
@gordonbondon gordonbondon deleted the upgrade-sys-go117 branch August 20, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants