Fix GeneratorsOfSemigroup immediate method for partial perm groups #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilfwilson
force-pushed
the
fix-generators-of-semigroup-for-partial-perm-group
branch
from
7742c9a
to
0126c4c
Compare
wilfwilson
force-pushed
the
fix-generators-of-semigroup-for-partial-perm-group
branch
from
0126c4c
to
b1f7579
Compare
wilfwilson
deleted the
fix-generators-of-semigroup-for-partial-perm-group
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a group of partial permutations was created without any
GeneratorsOfGroup, eg byS := Group([], PartialPerm([1, 2]));;, then theGeneratorsOfSemigroupimmediate method would return[], which is incorrect.This is what is currently causing the Travis tests to fail on
stable-3.1andmaster.