GASMAN problem in BIPART_LEFT_BLOCKS / BIPART_RIGHT_BLOCKS

[ChrisJefferson]

In BIPART_LEFT_BLOCKS and RIGHT_BLOCKS, t bipart.cc:616 on my machine, here is a line which looks like:

ADDR_OBJ(x)[1] = blocks_new_obj(bipart_get_cpp(x)->left_blocks());

That's illegal, as the left hand side gets evaluated first, then the right hand side can cause GC.

Found using the new memory canary in ( gap-system/gap#2293 ), just for information.

[flsmith]

Funnily enough we addressed this last week in PR #466.

It now reads

Obj o = blocks_new_obj(bipart_get_cpp(x)->left_blocks());
ADDR_OBJ(x)[1] = o;

[ChrisJefferson]

Woops, just a little bit too late. I had a quick try of some other functions, and couldn't find anything other obvious memory-related bugs.

[james-d-mitchell]

This is a duplicate of Issue #444, fixed in the 3.0.15 release, of two days ago 👍