Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Flask-WTF CSRF rule #3264

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Improve Flask-WTF CSRF rule #3264

merged 2 commits into from
Jan 8, 2024

Conversation

0xDC0DE
Copy link
Contributor

@0xDC0DE 0xDC0DE commented Jan 5, 2024

Related to RULES-6382

@0xDC0DE 0xDC0DE changed the title Improve Flask-WTF CSRF rules Improve Flask-WTF CSRF rule Jan 5, 2024
p4p3r
p4p3r approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@p4p3r p4p3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xDC0DE 0xDC0DE merged commit 25bd599 into develop Jan 8, 2024
8 checks passed
@0xDC0DE 0xDC0DE deleted the flask-wtf-csrf-disabled branch January 8, 2024 08:58
0xDC0DE added a commit that referenced this pull request Jan 9, 2024
@r2c-argo @0xDC0DE
Merge Develop into Release (#3268)
a40e5fa 
* Improve Flask-WTF CSRF rule (#3264)

* Improve Flask-WTF CSRF rules

* Add fixtest

* Add pattern-not for flask csrf tokens to django csrf rule (#3263)

---------

Co-authored-by: Pieter De Cremer (Semgrep) <pieter@r2c.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p4p3r p4p3r p4p3r approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xDC0DE @p4p3r