fix(multicore): Domain.join: do not lose backtrace #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajbt200128
approved these changes
Nov 14, 2025
dijkstracula
force-pushed
the
nathan/domain_join_reraise
branch
2 times, most recently
from
9f02555 to
ba15bac
Compare
When an exception from a joined domain is raised, the backtrace is lost. Instead, the backtrace the user gets indicates that it originated from Domain.join, as opposed to where the error occurred inside the domain. We (Semgrep) have started noticing this in CI runs, which makes pinning the root cause difficult. Note that this necessitated reordering `Domain` in stdlib/StdlibModules.
dijkstracula
force-pushed
the
nathan/domain_join_reraise
branch
from
ba15bac to
9415c91
Compare
Author
|
Turns out that this was an incomplete fix - we needed to capture and propagate the backtrace in the C side of things too. KC was good enough to fix up the patch here and I'll pull it in on our side when I have a moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an exception from a joined domain is raised, the backtrace is lost. Instead, the backtrace the user gets indicates that it originated from Domain.join, as opposed to where the error occurred inside the domain. We (Semgrep) have started noticing this in CI runs, which makes pinning the root cause difficult.