Skip to content

Commit

Permalink
chore(NA): improve kbn-ui-shared-deps-npm split (elastic#114557)
Browse files Browse the repository at this point in the history
* chore(NA): remove elastic-datemath from kbn-ui-shared-deps-npm

* chore(NA): remove @kbn deps on kbn ui shared deps npm

* chore(NA): missing peer dep to build kbn ui shared deps npm

* chore(NA): general improvements for kbn ui shared deps npm

* chore(NA): remove min size chunks plugin

* chore(NA): remove split chunks

* chore(NA): improve dep declaring on kbn-ui-shared-deps-src

* chore(NA): remove typo

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
  • Loading branch information
mistic and kibanamachine authored Oct 13, 2021
1 parent 3025942 commit ad9c158
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 13 deletions.
4 changes: 1 addition & 3 deletions packages/kbn-ui-shared-deps-npm/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ NPM_MODULE_EXTRA_FILES = [

RUNTIME_DEPS = [
"//packages/elastic-datemath",
"//packages/kbn-utils",
"@npm//@babel/runtime",
"@npm//@elastic/charts",
"@npm//@elastic/eui",
Expand Down Expand Up @@ -61,6 +60,7 @@ RUNTIME_DEPS = [
"@npm//rxjs",
"@npm//styled-components",
"@npm//symbol-observable",
"@npm//tslib",
"@npm//url-loader",
"@npm//val-loader",
"@npm//whatwg-fetch",
Expand All @@ -71,8 +71,6 @@ WEBPACK_DEPS = [
]

TYPES_DEPS = [
"//packages/elastic-datemath",
"//packages/kbn-utils",
"@npm//@elastic/charts",
"@npm//@elastic/eui",
"@npm//@elastic/numeral",
Expand Down
5 changes: 2 additions & 3 deletions packages/kbn-ui-shared-deps-npm/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ const webpack = require('webpack');
const { CleanWebpackPlugin } = require('clean-webpack-plugin');
const MiniCssExtractPlugin = require('mini-css-extract-plugin');

const { REPO_ROOT } = require('@kbn/utils');

const UiSharedDepsNpm = require('./src/index');

const MOMENT_SRC = require.resolve('moment/min/moment-with-locales.js');
const WEBPACK_SRC = require.resolve('webpack');

const REPO_ROOT = Path.resolve(__dirname, '..', '..');

module.exports = (_, argv) => {
const outputPath = argv.outputPath ? Path.resolve(argv.outputPath) : UiSharedDepsNpm.distDir;

Expand All @@ -40,7 +40,6 @@ module.exports = (_, argv) => {

// modules from npm
'@elastic/charts',
'@elastic/datemath',
'@elastic/eui',
'@elastic/eui/dist/eui_charts_theme',
'@elastic/eui/lib/services',
Expand Down
3 changes: 0 additions & 3 deletions packages/kbn-ui-shared-deps-src/.babelrc

This file was deleted.

3 changes: 0 additions & 3 deletions packages/kbn-ui-shared-deps-src/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ RUNTIME_DEPS = [
"//packages/kbn-monaco",
"//packages/kbn-std",
"//packages/kbn-ui-shared-deps-npm",
"//packages/kbn-utils",
]

TYPES_DEPS = [
Expand All @@ -50,9 +49,7 @@ TYPES_DEPS = [
"//packages/kbn-monaco",
"//packages/kbn-std",
"//packages/kbn-ui-shared-deps-npm",
"//packages/kbn-utils",
"@npm//@elastic/eui",
"@npm//resize-observer-polyfill",
"@npm//webpack",
]

Expand Down
3 changes: 2 additions & 1 deletion packages/kbn-ui-shared-deps-src/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,14 @@ const Path = require('path');

const webpack = require('webpack');
const MiniCssExtractPlugin = require('mini-css-extract-plugin');
const { REPO_ROOT } = require('@kbn/utils');
const UiSharedDepsNpm = require('@kbn/ui-shared-deps-npm');

const UiSharedDepsSrc = require('./src');

const MOMENT_SRC = require.resolve('moment/min/moment-with-locales.js');

const REPO_ROOT = Path.resolve(__dirname, '..', '..');

module.exports = {
node: {
child_process: 'empty',
Expand Down

0 comments on commit ad9c158

Please sign in to comment.