feat(diagnostics): fix provider metadata parity and bound process reads (ticket-023)

[tom-sapletta-com]

Fix native provider metadata decoding/line-limit parity and prevent blocking or unbounded session process reads (ticket-023).

[ifuri-validator-agent]

Validator approval after policy checks for exact head dda9d17552a48e68079e2f57c9ea9775859da855.

Ticket: ticket-023
Correlation ID: fleet-uncrash23-pr22-20261011
Model: openai/cursor-auto
Reviewed diff chunks: 3
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 3 diff chunk(s). The visible changes consistently bound process metadata reads, reject non-regular files, avoid following final-component symlinks, and preserve fallback handling for unavailable or malformed metadata. No unresolved code or security defect is evident in this chunk. All supplied protected required checks passed. | The visible chunk consistently converts silent native-scan failures into explicit fallback-triggering errors, bounds process-file reads, propagates worker-thread failures, and adds targeted parity tests for unsupported metadata encodings and JSON forms. No unresolved code or security defect is evident in this chunk, and all protected required checks passed. | The visible test chunk adds focused native/Python parity coverage for provider metadata line-size boundaries, unsafe FIFO/symlink inputs, traversal depth, and bounded process metadata reads. No unresolved code or security defects are evident in this chunk, and all protected required checks passed.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.

Actual PR impact radar

Exact range: 2d82ec367845db10774eb7c1645e0fb8d67bea60...dda9d17552a48e68079e2f57c9ea9775859da855
Change digest: 61b0be135776a410eea99c1c7230a1efab5234681294975d9785c6192a74f477
Score: 56/100 (L), estimated 63 min, split recommended: true
Affected services/components: repository-wide/unclassified

Machine-readable radar JSONL and SVG

{"actual_change":{"additions":336,"base_sha":"2d82ec367845db10774eb7c1645e0fb8d67bea60","binary_files":0,"categories":{"code":2,"configuration":1,"docs":2,"tests":1},"change_digest":"61b0be135776a410eea99c1c7230a1efab5234681294975d9785c6192a74f477","comparison":"2d82ec367845db10774eb7c1645e0fb8d67bea60...dda9d17552a48e68079e2f57c9ea9775859da855","deletions":81,"file_count":6,"files":["project/TICKETS.md","project/ticket-023/README.md","project/ticket-023/intent.json","src/uncrash/diagnostics.py","src/uncrash/snapshot.rs","tests/test_diagnostics.py"],"head_sha":"dda9d17552a48e68079e2f57c9ea9775859da855","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":4,"delivery":2,"scope":4,"uncertainty":3,"validation":1},"complexity":"L","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":63,"within_budget":false},"impact":{"components":["decoding","project","src/uncrash","tests"],"files":["decoding/line-limit","project/TICKETS.md","project/ticket-023/README.md","project/ticket-023/intent.json","src/uncrash/diagnostics.py","src/uncrash/snapshot.rs","tests/test_diagnostics.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":56,"split":{"parts":[{"estimated_minutes":14,"name":"Implement decoding","scope":["decoding"]},{"estimated_minutes":14,"name":"Implement project","scope":["project"]},{"estimated_minutes":14,"name":"Implement src/uncrash","scope":["src/uncrash"]},{"estimated_minutes":14,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-023"}

<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-023: feat(diagnostics): fix provider metadata parity and bound process reads (ticket-023)</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,30 97,53 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">L · 63m</text></svg>

Merge will be attempted after this approval when explicitly authorized. ## Decision record (recomputable)

DECISION D-023-4481
TICKET ticket-023
HEAD_SHA dda9d17552a48e68079e2f57c9ea9775859da855
CORRELATION_ID fleet-uncrash23-pr22-20261011
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["governance / enforce=PASS","governance / remote lifecycle=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["governance / enforce","governance / remote lifecycle","onedev/local-verify"]
INPUT required_checks_source = "protected registry (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/uncrash","pull_request":22,"head_sha":"dda9d17552a48e68079e2f57c9ea9775859da855","base_sha":"2d82ec367845db10774eb7c1645e0fb8d67bea60","diff_sha256":"706dd5d1715c8f13990b981a7f7e49b2d8f67313c8560d68a52f5aee714f050c"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["project/TICKETS.md","project/ticket-023/README.md","project/ticket-023/intent.json","src/uncrash/diagnostics.py","src/uncrash/snapshot.rs","tests/test_diagnostics.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"2d82ec367845db10774eb7c1645e0fb8d67bea60","head_sha":"dda9d17552a48e68079e2f57c9ea9775859da855","change_digest":"61b0be135776a410eea99c1c7230a1efab5234681294975d9785c6192a74f477","score":56,"complexity":"L","estimated_minutes":63,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"