Repository navigation
feat(ticket-018): accelerate panic log scanning and diagnostics with native Rust worker - #17
Conversation
…native Rust worker
There was a problem hiding this comment.
Validator approval after policy checks for exact head 128493c510130433e2ff9b8722bfb94e169ecd8c.
Ticket: ticket-018
Correlation ID: local-semcod-uncrash-pr-17-ticket-018
Model: openai/cursor-auto
Reviewed diff chunks: 2
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 2 diff chunk(s). Chunk 1 adds native --scan-panics scanning in Rust with symlink/NOFOLLOW guards and JSON escaping, plus a Python wrapper that prefers the native worker and falls back safely. Required protected checks all PASS. Visible integration looks coherent for this chunk; minor behavioral and typing notes only. | Chunk 2 adds native --scan-panics wiring, find_native_worker discovery with ownership/mode/no-link hardening, and parity/fallback/discovery tests. Required checks all PASS (governance enforce, remote lifecycle, onedev/local-verify). Visible changes look consistent and defensive; no unresolved code or security defects in this chunk.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.
Actual PR impact radar
Exact range: b7865c50d0c18c86b6f1488bb9062a626525b57d...128493c510130433e2ff9b8722bfb94e169ecd8c
Change digest: 3277f98b45d91a00ede123cb08e4fb73f553196a8ff11204a67e6edb69d2d325
Score: 48/100 (M), estimated 55 min, split recommended: true
Affected services/components: repository-wide/unclassified
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":366,"base_sha":"b7865c50d0c18c86b6f1488bb9062a626525b57d","binary_files":0,"categories":{"code":3,"configuration":1,"docs":1,"tests":1},"change_digest":"3277f98b45d91a00ede123cb08e4fb73f553196a8ff11204a67e6edb69d2d325","comparison":"b7865c50d0c18c86b6f1488bb9062a626525b57d...128493c510130433e2ff9b8722bfb94e169ecd8c","deletions":3,"file_count":6,"files":["project/ticket-018/README.md","project/ticket-018/intent.json","src/uncrash/diagnostics.py","src/uncrash/snapshot.rs","src/uncrash/store.py","tests/test_diagnostics.py"],"head_sha":"128493c510130433e2ff9b8722bfb94e169ecd8c","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":3,"delivery":2,"scope":3,"uncertainty":3,"validation":1},"complexity":"M","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":55,"within_budget":false},"impact":{"components":["project","src/uncrash","tests"],"files":["project/ticket-018/README.md","project/ticket-018/intent.json","src/uncrash/diagnostics.py","src/uncrash/snapshot.rs","src/uncrash/store.py","tests/test_diagnostics.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":48,"split":{"parts":[{"estimated_minutes":15,"name":"Implement project","scope":["project"]},{"estimated_minutes":15,"name":"Implement src/uncrash","scope":["src/uncrash"]},{"estimated_minutes":15,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-018"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-018: feat(ticket-018): accelerate panic log scanning and diagnostics with native Rust worker</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,38 89,56 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">M · 55m</text></svg>DECISION D-018-1392
TICKET ticket-018
HEAD_SHA 128493c510130433e2ff9b8722bfb94e169ecd8c
CORRELATION_ID local-semcod-uncrash-pr-17-ticket-018
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["governance / enforce=PASS","governance / remote lifecycle=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["governance / enforce","governance / remote lifecycle","onedev/local-verify"]
INPUT required_checks_source = "protected registry (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/uncrash","pull_request":17,"head_sha":"128493c510130433e2ff9b8722bfb94e169ecd8c","base_sha":"b7865c50d0c18c86b6f1488bb9062a626525b57d","diff_sha256":"fdd2291451a6ae61a8bba05df6734e32f4fe0aeeb08f02fe683cfa1bf1d1f9d2"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["project/ticket-018/README.md","project/ticket-018/intent.json","src/uncrash/diagnostics.py","src/uncrash/snapshot.rs","src/uncrash/store.py","tests/test_diagnostics.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"b7865c50d0c18c86b6f1488bb9062a626525b57d","head_sha":"128493c510130433e2ff9b8722bfb94e169ecd8c","change_digest":"3277f98b45d91a00ede123cb08e4fb73f553196a8ff11204a67e6edb69d2d325","score":48,"complexity":"M","estimated_minutes":55,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
Summary
src/uncrash/snapshot.rswith native--scan-panics <dir> [budget]CLI mode.src/uncrash/diagnostics.pywith fast discovery and seamless Python fallback.find_native_workerinsrc/uncrash/store.pyto locate precompiled workers withoutrustccompiler latency.tests/test_diagnostics.pyvalidating exact parity between native and Python scanners, edge-case rejection, and fallback.