Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Goerli from supported networks #569

Merged
merged 5 commits into from
Jan 23, 2024
Merged

Remove Goerli from supported networks #569

merged 5 commits into from
Jan 23, 2024

Conversation

cedoor
Copy link
Member

@cedoor cedoor commented Jan 17, 2024 •
edited
Loading

Related Issue

Closes #352

Does this introduce a breaking change?

  • Yes
  • No

0xjei
0xjei reviewed Jan 17, 2024
View reviewed changes
Copy link
Contributor

@0xjei 0xjei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good so far! I only noticed one small (potential) oversight in the docs. We just need to wait for the ethers fix for merge 😊

package.json Show resolved Hide resolved
packages/cli/README.md Show resolved Hide resolved
packages/cli/src/index.ts Show resolved Hide resolved
@cedoor cedoor linked an issue Jan 19, 2024 that may be closed by this pull request
Remove Goerli from the supported networks #352
Closed
@cedoor cedoor merged commit 4e33b01 into feat/semaphore-v4 Jan 23, 2024
3 checks passed
@cedoor cedoor deleted the chore/new-testnets branch January 23, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xjei 0xjei 0xjei left review comments

@vplasencia vplasencia vplasencia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Goerli from the supported networks
3 participants
@cedoor @0xjei @vplasencia