Skip to content

Conversation

@brech1
Copy link
Collaborator

@brech1 brech1 commented Apr 1, 2025

Description

This PR introduces a restructuring of the semaphore-rs crate.

Changes

  • Updates to Rust 2024 edition and arkworks cryptographic libraries
  • Adds a Baby Jubjub curve implementation adhering to EIP-2494 specs
  • Adds general error handling with specific error types
  • Implements identity and group modules
  • Adds integration tests for identity operations

Related Issue(s)

Checklist

  • I have read and understand the contributor guidelines and code of conduct.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run cargo fmt without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Comment on lines 3 to 5
pub mod proof;

pub mod utils;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you keep these two files,
we still need this prover structure

@brech1 brech1 force-pushed the restructure/crate branch from d720cd7 to 3a736b5 Compare April 2, 2025 02:44
@KimiWu123 KimiWu123 mentioned this pull request Apr 9, 2025
@KimiWu123 KimiWu123 requested a review from vplasencia April 10, 2025 01:48
@KimiWu123 KimiWu123 requested review from KimiWu123 and removed request for vplasencia April 15, 2025 06:41
@KimiWu123 KimiWu123 merged commit 6f00c4b into semaphore-protocol:main Apr 15, 2025
2 checks passed
@brech1 brech1 deleted the restructure/crate branch April 17, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Identity implementation

3 participants