Specification inconsistencies

[oxlade39]

I've been trying to write a Java library corresponding to this specification here.

I've gotten reasonably far in creating POJOs for the majority of the spec as described in this repo.

In order to verify this, I have written a parameterized test that fetches each of your listed SML examples from here

In doing so I have found a number of inconsistencies in the examples and the spec. I have made a number of compromises which I will list below but even having done so there are still 4 tests failing. I have also raised PRs in the repositories for the examples where required, which I will also list below.

I'm happy to contribute to correcting the spec if you feel that is appropriate?

Inconsistencies Found:

• AttributeReference-relationshipPath
• From
  • hierarchy
  • level
  • joinColumn
• Hierarchy-description
• Level-parallelPeriods
• Metric-folder
• Model-visible
• All of ParallelPeriods
• Partition-relationshipsPath
• SecondaryAttribute
  • associatedHierarchy
  • containsUniqueNames
  • isUniqueKey

PRs raised

• fix visible sml-models-tutorials-adventureworks2012#1
• Correct {{ syntax in yaml sml-models-tutorials-tpch#2
• fix typo in the description attribute sml-models-tutorials-tpcds#3

[oxlade39]

You can see examples of the failures in the pipeline for example here