Skip to content

Issue 45: implement the stix 21 report type vocabulary #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

brett-heffelfinger
Copy link
Contributor

Closes #45

@brett-heffelfinger brett-heffelfinger self-assigned this Jun 6, 2025
@brett-heffelfinger brett-heffelfinger linked an issue Jun 6, 2025 that may be closed by this pull request
@brett-heffelfinger
Copy link
Contributor Author

Making a comment to note that I don't think the skos:prefLabels are an appropriate level of description for the subject of the categories and may need revisions.

brett-heffelfinger and others added 3 commits June 6, 2025 11:21
Co-authored-by: Michael Uschold <uscholdm@users.noreply.github.com>
Co-authored-by: Michael Uschold <uscholdm@users.noreply.github.com>
Co-authored-by: Michael Uschold <uscholdm@users.noreply.github.com>
@uscholdm
Copy link
Contributor

uscholdm commented Jun 6, 2025

Making a comment to note that I don't think the skos:prefLabels are an appropriate level of description for the subject of the categories and may need revisions.

I don't follow, e.g. the following looks fine to me:

gist:_ReportType_campaign
	a gist:ReportType ;
	skos:definition """STIX 2.1 Description: 
Report subject is a characterization of one or more campaigns and related information."""^^xsd:string ;
	skos:prefLabel "Campaign"^^xsd:string ;
	gist:stixTerm "campaign"^^xsd:string ;
	.

Give an example of your concern.

@brett-heffelfinger
Copy link
Contributor Author

Give an example of your concern.

I'm thinking along the lines of the distinction of a Campaign itself and a report that's on a Campaign - the IRIs make the distinction for us, but I just think there might be room to make the prefLabel a bit clearer to distinguish the two. It's not really a big issue overall but it's just how I felt while I was writing out the triples.

@uscholdm
Copy link
Contributor

uscholdm commented Jun 6, 2025

Give an example of your concern.

I'm thinking along the lines of the distinction of a Campaign itself and a report that's on a Campaign - the IRIs make the distinction for us, but I just think there might be room to make the prefLabel a bit clearer to distinguish the two. It's not really a big issue overall but it's just how I felt while I was writing out the triples.

Ah I see. The possible ambiguity should be minimized from context; also labels are meant to be short is possible. Let;s see what @rhohimer thinks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the STIX 2.1 Report Type vocabulary
2 participants